SPE: SPEC file SRP: SRPM file RPM: RPM files log: build log assignee: who is going to do the check don: DONE x: this type of input is needed to do the check MUST : required by the guidelines SHOULD: recommended by the guidelines X: already implemented SPE-SRP-RPM-log-assignee-don [x]-[ ]-[ ]-[ ]-[ ]-[ ] SHOULD: Group tag must make sense. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : The package must be named according to the Package Naming Guidelines . [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines . [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : Latest version is packaged. [x]-[ ]-[ ]-[ ]-[ ]-[ ] SHOULD: Dist tag is present and proper. [x]-[ ]-[ ]-[ ]-[ ]-[ ] SHOULD: Patches should be explained and be submitted to upstream. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : The License field in the package spec file must match the actual license. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : The spec file must be written in American English. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : The spec file for the package MUST be legible. If the reviewer is unable to read the spec file, it will be impossible to perform a review. Fedora is not the place for entries into the Obfuscated Code Contest (http://www.ioccc.org/). [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. Refer to the Guidelines for examples. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : A package must not contain any duplicate files in the %files listing. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. [x]-[ ]-[ ]-[ ]-[ oget ]-[X] MUST : Buildroot must be one of these: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : Each package must have a %clean section, which contains rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : At the beginning of %install, each package MUST run rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). See Prepping BuildRoot For %install for details. [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : Each package must consistently use macros, as described in the macros section of Packaging Guidelines . [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : ScriptletSnippets are used properly. (for icons, fonts, mimeinfo, desktop-database, gconf, texinfo, scrollkeeper) Follow: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [x]-[ ]-[ ]-[ ]-[ ]-[ ] MUST : Packages must not own files or directories already owned by other packages. [x]-[x]-[ ]-[ ]-[ ]-[ ] MUST : The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [x]-[x]-[ ]-[ ]-[ ]-[ ] MUST : The file, containing the text of the license(s) for the package must be included in %doc if (and only if) the source package includes the text of the license(s) in its own file. [x]-[x]-[ ]-[ ]-[ ]-[ ] MUST : The sources used to build the package must match the upstream source, as provided in the spec URL. [x]-[x]-[ ]-[ ]-[ ]-[ ] MUST : The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [x]-[x]-[ ]-[ ]-[ ]-[ ] SHOULD: Search for /usr/lib and /usr/local inside the source, make sure that they are handled properly. [x]-[x]-[ ]-[ ]-[ ]-[ ] MUST : Remove precompiled binaries. [x]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [x]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [x]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [x]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. Follow: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files [x]-[x]-[x]-[ ]-[ ]-[ ] MUST : Large documentation files should go in a -doc subpackage. [x]-[x]-[x]-[ ]-[ ]-[ ] MUST : rpmlint must be run on every package. The output should be posted in the review. [x]-[x]-[x]-[ ]-[ ]-[ ] SHOULD: All relevant doc files should be packaged. [x]-[x]-[x]-[ ]-[ ]-[ ] MUST : package must obey the specific Guidelines (python, java etc) http://fedoraproject.org/wiki/Packaging/Guidelines#Application_Specific_Guidelines [x]-[ ]-[ ]-[x]-[ ]-[ ] MUST : Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. [ ]-[x]-[ ]-[ ]-[ ]-[ ] MUST : The package must contain code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines . [ ]-[x]-[x]-[ ]-[ ]-[ ] MUST : All filenames in rpm packages must be valid UTF-8. [ ]-[ ]-[x]-[x]-[ ]-[ ] MUST : The package must successfully compile and build into binary rpms on at least one supported architecture. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Header files must be in a -devel package. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : If there is a -devel package, check for the header files inside the package to figure out "Requires:" for the -devel package. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Static libraries must be in a -static package. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : Packages must NOT contain any .la libtool archives, these should be removed in the spec. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : package installs and removes properly. [ ]-[ ]-[x]-[ ]-[ ]-[ ] MUST : final provides and requires are sane [ ]-[ ]-[ ]-[x]-[ ]-[ ] MUST : Compiler flags must be appropriate. [ ]-[ ]-[ ]-[x]-[ ]-[ ] MUST : package builds in mock